Repository navigation
chore(deps): bump vLLM floor to 0.26 and refresh docker matrix - #1971
Conversation
0.26 caps fastapi<0.137 itself, so the CI installer's explicit pin is dropped. Release-docker matrix moves to v0.26.0/v0.25.0/v0.23.0 (there is no v0.24.x vllm-openai tag). Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdates the Docker release workflow and CI installation script to use vLLM 0.26.0 defaults, fallback images, examples, and minimum version requirements. ChangesvLLM version alignment
| Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
👋 The PR description doesn't fully follow
Please update the PR description so reviewers have the context they need. |
Description
Problem
The CI installer floors vLLM at 0.25.0 with a manual
fastapi<0.137pin, and the release-docker matrix tops out atv0.22.1— four minor versions behind upstream 0.26.0.Solution
scripts/ci_install_vllm.sh: floor raised tovllm>=0.26.0; the explicitfastapi<0.137pin is dropped because 0.26's own metadata capsfastapi[standard]<0.137.0,>=0.133.0(verified from the wheel's requires_dist). The torchcodec/FFmpeg canary and--torch-backend=autoare unchanged.release-vllm-docker.yml: 3-version matrix →v0.26.0 / v0.25.0 / v0.23.0, defaults and examples →v0.26.0. All three tags verified on Docker Hub; note there is nov0.24.xvllm-openaitag, hencev0.23.0as the third entry.grpc_servicer'svllm>=0.19.0floor is untouched.Test Plan
bash -nclean; 0.26.0 requires_dist verified for the fastapi cap; all matrix image tags verified.Checklist
cargo +nightly fmtpassescargo clippy --all-targets --all-features -- -D warningspassesSummary by CodeRabbit